[regression] Syntax error with "if" on multiple lines #2850
Comments
|
Thanks for submitting this. We'll look at the config parser on this. Here's a shorter potential workaround: |
|
@untergeek Is this issue will be fixed before the 1.5.0 release ? |
|
I just hit this with 1.5.0 RC4. We've lots of conditionals spread over multiple lines interspersed with comment lines explaining the condition expression that follows. Untangling those is a pain and ends up with a block of comments followed by one very very long condition expression that's hard to read. |
|
@timbunce for clarity, this is a bug and a regression. :) |
jordansissel
changed the title
|
Testing this: [14] pry(main)> a = LogStashConfigParser.new; config = a.parse("filter { if [foo]\n or [bar]\n or [baz] { test { } } }");; puts config.compile
...
def cond_func_1(input_events)
result = []
input_events.each do |event|
events = [event]
if ((event["[foo]"]) or (event["[bar]"]) or (event["[baz]"])) # if [foo]
or [bar]
or [baz]
events = @filter_test_3.multi_filter(events)
end
result += events
end
result
end |
|
The bug in the compiled code is this generation: if ((event["[foo]"]) or (event["[bar]"]) or (event["[baz]"])) # if [foo]
or [bar]
or [baz]It's including the 'or [bar]' for some reason. I'll take a look at the config AST to figure out what's causing this. |
|
Haha, this bug... The bug is that it takes your logstash config and tries to embed it in a comment in the compiled code (for easier debugging), but there are newlines, which make it invalid ruby code - when compiled. This should be an easy fix. The line of code that causes it was introduced in 4211522 (April 2012), so I'm not yet sure how this only affects 1.5.0 and not 1.4.2. |
|
I can confirm that 4211522 isn't included in 1.4.2 |
Logstash's config compiler adds a comment to the compiled code, like
if ..... # if [your] and [conditional]
The idea is to to help aid in reading the compiled logstash config.
However, if a conditional has newlines in it, the `#text_value` of
that conditional will have newlines, and we'll accidentally create
invalid ruby code which will fail with SyntaxError.
Prior to this change, the following Logstash config, under 1.5.0,
would cause a crash on startup:
if [some]
or [condition] {
...
}
The cause was that Logstash would compile this to:
if event("[some]"]) || event("[condition]") # if [some]
or [condition]
...
end
The 2nd line there `or [condition]` was intended to be on the line
above.
This change strips the line terminators \r and \n, just in case, and
provides a test case to cover.
I verified that this test case _fails_ without the config_ast.rb patch
and _succeeds_ with the patch.
Fixes elastic#2850
|
#3281 has a fix for this. |
Logstash's config compiler adds a comment to the compiled code, like
if ..... # if [your] and [conditional]
The idea is to to help aid in reading the compiled logstash config.
However, if a conditional has newlines in it, the `#text_value` of
that conditional will have newlines, and we'll accidentally create
invalid ruby code which will fail with SyntaxError.
Prior to this change, the following Logstash config, under 1.5.0,
would cause a crash on startup:
if [some]
or [condition] {
...
}
The cause was that Logstash would compile this to:
if event("[some]"]) || event("[condition]") # if [some]
or [condition]
...
end
The 2nd line there `or [condition]` was intended to be on the line
above.
This change strips the line terminators \r and \n, just in case, and
provides a test case to cover.
I verified that this test case _fails_ without the config_ast.rb patch
and _succeeds_ with the patch.
Fixes #2850
Fixes #3281
|
Thank you Jordan!
|
This is a followup of the issues elastic#2850 and elastic#3281. The following configuration: if [condition] { } else if [condition1] or [condition2] { .. } Was compiled to ruby like this: elsif condition or condition2 # else if [condition1] or [condition2] and making the intepreter fails.
This is a followup of the issues elastic#2850 and elastic#3281. The following configuration: if [condition] { } else if [condition1] or [condition2] { .. } Was compiled to ruby like this: elsif condition or condition2 # else if [condition1] or [condition2] and making the intepreter fails.
Just tried 1.5.0 RC2 and got a syntax error with my configuration file (worked fine in 1.4.2):
Here is the culprit block from the configuration file
filtersection:Workaround: put all "or" conditions on the same line.
The text was updated successfully, but these errors were encountered: