Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone warning is displayed when pluginpath is used #4562

Closed
suyograo opened this issue Jan 25, 2016 · 2 comments
Closed

Milestone warning is displayed when pluginpath is used #4562

suyograo opened this issue Jan 25, 2016 · 2 comments

Comments

@suyograo
Copy link
Contributor

--pluginpath can be used with LS to load plugins which are not converted into RubyGems yet. LS will output a warning when used with this option:

:message=>"abc plugin is using the 'milestone' method to declare the version of the plugin this method is deprecated in favor of declaring the version inside the gemspec.", :level=>:warn}

This is a benign message, and can be ignored, but we need to remove this warning so it does not confuse users.

@suyograo suyograo changed the title Milestone warning error is displayed when pluginpath is used Milestone warning is displayed when pluginpath is used Jan 25, 2016
@ph
Copy link
Contributor

ph commented Feb 1, 2016

I came around this issue myself when working on metrics, I suggest we move the log level to debug?

@ph
Copy link
Contributor

ph commented Feb 1, 2016

And we remove the support for milestone in the next major version.

ph added a commit to ph/logstash that referenced this issue Feb 1, 2016
This PR change the log level when a user load a plugin with a milestone
option to debug instead of warn.

Fixes: elastic#4562
elasticsearch-bot pushed a commit that referenced this issue Feb 3, 2016
This PR change the log level when a user load a plugin with a milestone
option to debug instead of warn.

Fixes: #4562

Fixes #4603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants