Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins to conform to new output delegator #5663

Closed
5 tasks done
andrewvc opened this issue Jul 20, 2016 · 0 comments
Closed
5 tasks done

Update plugins to conform to new output delegator #5663

andrewvc opened this issue Jul 20, 2016 · 0 comments

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Jul 20, 2016

Given the issues presented in #5662 we need to mass update all plugins to use the correct concurrency strategy (introduced in #5752).

We need to figure out which plugins will use :single, :shared, or :legacy_worker as concurrency strategies.

Ideally none would use :legacy, but time likely does not permit that. High impact plugins should be converted to shared if they actually are concurrent if possible. This means moving away from a worker model for these plugins however. This is advantageous for some plugins, like output-rabbitmq, which can use shared to more efficiently use the connection (RMQ does channel multiplexing over TCP connections).

Many other plugins, like stdout should move to the :single model, which disables the workers setting and allows only a single synchronized instance.

Some plugins need to move because they use the legacy instance method workers_not_supported. These plugins are:

@andrewvc andrewvc changed the title Determine which outputs need to become threadsafe ASAP Mass update plugins to conform to new output delegator Aug 11, 2016
@ph ph changed the title Mass update plugins to conform to new output delegator Update plugins to conform to new output delegator Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants