Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default URL+credentials for Kibana if ES info is present #8422

Closed
tbragin opened this issue Oct 3, 2017 · 4 comments
Closed

Set default URL+credentials for Kibana if ES info is present #8422

tbragin opened this issue Oct 3, 2017 · 4 comments

Comments

@tbragin
Copy link

tbragin commented Oct 3, 2017

When loading the dashboards from Logstash modules in 5.6 and 6.0, the user needs to configure:

Elasticsearch URL
Kibana URL
Elasticsearch credentials
Kibana credentials

Beats introduced logic whereby if user supplies ES URL + credentials but no Kibana credentials, we automatically try to use ES info for both ES and Kibana: elastic/beats#4867

This allows for getting started instructions to be simpler.

cc: @acchen97 @robbavey

@robbavey robbavey self-assigned this Oct 12, 2017
@robbavey
Copy link
Member

@tbragin @acchen97 Do we want to use the elasticsearch URL (which would need the port changing, and handling multiple es hosts) or just the credentials?

AFAICT, the beats commit just uses the elasticsearch credentials if Kibana credentials are not set, and does not attempt to do anything with the url.

robbavey added a commit to robbavey/logstash that referenced this issue Oct 12, 2017
If modules configuration has elasticsearch credentials set, but not
kibana, attempt to use elasticsearch credentials for Kibana login.

Fixes elastic#8422
robbavey added a commit to robbavey/logstash that referenced this issue Oct 12, 2017
If modules configuration has elasticsearch credentials set, but not
kibana, attempt to use elasticsearch credentials for Kibana login.

Fixes elastic#8422
@acchen97
Copy link
Contributor

@robbavey good question, it'd be ideal to have a consistent experience across both Beats and LS modules.

@monicasarbu @brandonmensing any background on why on the KB credentials are defaulted, but not the URL? It feels like it would be more complete if the URL was defaulted to ES URL too (with port changed to 5601).

@brandonmensing
Copy link

I believe it's just the creds, not the URL. We use local+port as we always had. Using the ES URL would be problematic in that there can be multiple and anyone who has multiple ES would be in production so they should be using Kibana on the ES host anyway, right?

@acchen97
Copy link
Contributor

@brandonmensing yeah you're right, and plus ES hosts can likely be an array as well.

@robbavey let's go ahead and follow the same semantics as Beats. For KB, the credentials should fallback to the ES credentials and the URL to localhost:5601, if not specified.

elasticsearch-bot pushed a commit that referenced this issue Oct 13, 2017
If modules configuration has elasticsearch credentials set, but not
kibana, attempt to use elasticsearch credentials for Kibana login.

Fixes #8422

Fixes #8482
elasticsearch-bot pushed a commit that referenced this issue Oct 13, 2017
If modules configuration has elasticsearch credentials set, but not
kibana, attempt to use elasticsearch credentials for Kibana login.

Fixes #8422

Fixes #8482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants