Add Zing JVM to the list of supported garbage collectors. #10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Hi, can somebody please clarify is there smth I can do for that revision? CLA is sgined and all the checks are green now. |
|
jenkins test this please |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Dec 10, 2018
elasticsearch-bot
pushed a commit
that referenced
this pull request
Dec 10, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested benchmark-cli.jar: all the metrics get reproted after applying of the change.
This is not a cosmetic issue. When x-pack metrics are enabled in logstash (xpack.monitoring.elasticsearch.url option) logstash refuses even to start properly since monitoring pipeline keeps crashing (as there are no valid GC data)
Failed to create monitoring event {:message=>"For path: http_address. Map keys: [:stats, :jvm, :os]", :error=>"LogStash::Instrument::MetricStore::MetricNotFound"}