Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update breaking changes doc for 7.0 #10632
[WIP] Update breaking changes doc for 7.0 #10632
Changes from 4 commits
6cd2fb5
ec3f75e
78d37bf
1bd73b3
124be0f
b2f0d32
e0ecc8e
bf3c60f
5e2de91
5cd6131
ff14f95
fe41afe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
section should be above
breaking-pq
section to maintain newest-first orderingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take out this link if y'all don't think it is needed or appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes let's remove this reference to supported plugins please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a note here that seeing a mapping conflict after upgrade is an indication that is change is influencing the data reaching existing indices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
These breaking changes aren't in the Beats Input itself, but in the payloads that Beats sends. If a user upgrades Logstash before upgrading Beats, the payloads will continue to have the pre-ECS schema, and if they upgrade their Beats before upgrading Logstash they'll get payloads with the ECS schema in advance of any Logstash upgrade.
I would rather add this as a call-out than in bullet-points. See my proposed diff above for a
WARNING
call-out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaauie can we add here that in 7.0 ILM will be auto detected and enabled by default if the ES cluster supports it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a peek at what's coming in my next commit:
Comments are welcomed, pre- or post-commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only the graphite output stopped being supported but it's still in the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any notation required around that?
I'll remove this section entirely.
Would it be helpful to suggest that the user revisit the list of supported plugins as of 7.0? Or am I overthinking this. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this section, commercial support is something only for our customers, which can be checked in our support matrix page