Backport PR #12784 (#12805) to 7.12: Fix: logstash-keystore failing with an error #12804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: missing password dependency require which causes `bin/logstash-keystore` to fail with an error: ``` ERROR: Failed to load settings file from "path.settings". Aborting... path.setting=/logstash-7.12.0/config, exception=NameError, message=>uninitialized constant LogStash::Util::Password ``` * Fix: review all LS parts depending on Password * Test: bin/logstash-keystore create/list (cherry picked from commit e8e393b)
kares
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #12784 (and #12805) to 7.12 branch. Original message:
bin/logstash-keystore listis failing with:What does this PR do?
Fixes a regression introduced in LS 7.11, see #12783
Why is it important/What is the impact to the user?
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)How to test this PR locally
run
bin/logstash-keystore listRelated issues
Closes #12783