Fixed Cisco ASA firewalls patterns for outbound and inbound directions #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -11,10 +11,16 @@ CISCO_REASON Duplicate TCP SYN|Failed to locate egress interface|Invalid transpo | |||
| CISCO_DIRECTION Inbound|inbound|Outbound|outbound | |||
| CISCO_INTERVAL first hit|%{INT}-second interval | |||
| CISCO_XLATE_TYPE static|dynamic | |||
| # ASA-2-106001 | |||
There was a problem hiding this comment.
I believe 106001, 106006, 106007, and 106010 were correct as-is because they say from/src to/dst in the log message.
jordansissel
force-pushed
the
master
branch
from
f86287d
to
a536eef
Compare
|
Closing this PR as it got moved to logstash-plugins/logstash-patterns-core#47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the built-in patterns for Cisco ASA firewalls. When the direction is "outbound", the src_ip/src_port and dst_ip/dst_port are reversed. This PR fixes this.
The Logstash Cookbook should be updated for this purpose, see #1369.