Backport PR #14515 to 8.4: Fix Windows scripts #14516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The work done in #14355 to fix the keystore and plugin scripts erroneously included %JAVA_OPTS% in the command to invoke `jruby`, rather than as an environment variable, which prevented these scripts from operating correctly, due to `jruby.exe` not handling Java options, causing the scripts to crash on invocation. This commit removes the %JAVA_OPTS% - this is already set as an environment variable, and allows the scripts to operate correctly (cherry picked from commit 5d7fa78)
kaisecheng
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #14515 to 8.4 branch, original message:
The work done in #14355 to fix the keystore and plugin scripts erroneously included %JAVA_OPTS% in the command to invoke
jruby, rather than as an environment variable, which prevented these scripts from operating correctly, due tojruby.exenot handling Java options, causing the scripts to crash on invocation.This commit removes the %JAVA_OPTS% - this is already set as an environment variable, and allows the scripts to operate correctly