Fix wildcards in pipeline IDs version #14950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📃 DOCS PREVIEW ✨ https://logstash_14950.docs-preview.app.elstc.co/diff |
mashhurs
reviewed
Mar 10, 2023
| @@ -14,6 +14,6 @@ xpack.management.pipeline.id: ["*logs", "*apache*", "tomcat_log"] | |||
|
|
|||
| In this example, `"*logs"` matches all IDs ending in `logs`. `"*apache*"` matches any IDs with `apache` in the name. | |||
|
|
|||
| Wildcard in pipeline IDs is available starting with Elasticsearch 7.10. Logstash can pick up new pipeline without a restart if the new pipeline ID matches the wildcard pattern. | |||
| Wildcard in pipeline IDs is available starting with Elasticsearch 7.11. Logstash can pick up new pipeline without a restart if the new pipeline ID matches the wildcard pattern. | |||
There was a problem hiding this comment.
@jonny-mcc, the sources you are mentioning are belong to Logstash and this statement says Logstash index REST API is available in Elasticsearch v7.10, which is not about Logstash. Please give your suggestion if this statement is confusing.
Suggested change
| Wildcard in pipeline IDs is available starting with Elasticsearch 7.11. Logstash can pick up new pipeline without a restart if the new pipeline ID matches the wildcard pattern. | |
| Wildcard in pipeline IDs is available starting with Elasticsearch 7.10. Logstash can pick up new pipeline without a restart if the new pipeline ID matches the wildcard pattern. |
|
To clarify: the feature to support wildcard pipelines in Central Management was shipped in Logstash 7.11, but it depends on an Elasticsearch feature that was shipped with Elasticsearch 7.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The docs state that wildcards in the pipeline IDs are allowable from version 7.10 onwards. This is incorrect as the code to do this was only added in 7.11. This can be seen if you compare the files in question between the 7.10 and 7.11 branches - the function get_wildcard_pipelines does not exist in 7.10.
7.10 =>
logstash/x-pack/lib/config_management/elasticsearch_source.rb
Line 224 in 4344a87
7.11 =>
logstash/x-pack/lib/config_management/elasticsearch_source.rb
Line 224 in 866633f
Why is it important/What is the impact to the user?
Users will try and use wildcards in pipeline IDs and find that they do not work. This is a poor user experience
Related issues
Original PR to allow wildcard file IDs - #12370