Reintroduce bundler 2.4 #14995
Merged
Reintroduce bundler 2.4 #14995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jsvd
commented
Apr 11, 2023
jsvd
commented
- reintroduce bundler 2.4 and remove tweaks for 2.3
- avoid memory leak during generatePluginsVersion
- skip logstash-input-cloudwatch to avoid bundler 2.4 struggling with dependency resolution
…luginsVersion for some reason, instances of Bundler::Dsl are retained in org.jruby.MetaClass. Each Bundler::Dsl will retain Bundler::SourceList which is > 150MB. This commit sets the internal state of each Dsl's source list so the large objects can be collected. The proper fix would be to either reuse a single Dsl object or fix the code upstream to avoid having Dsl objects retained by org.jruby.MetaClass.
the new bundler 2.4's resolution algorithm seems to struggle in certain situations, like resolving combination of "logstash-input-cloudwatch" and "logstash-integration-aws". Until the issue is solved let's skip it.
andsel
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
LGTM
Tested locally resulted in
Successfully installed: logstash-input-elastic_serverless_forwarder
Successful: 185/207
Failures: 19/207
Execution of label: batch install of plugins, 2094.376126s
Generating: /path/to/logstash/plugins_version_docs.json
Checking if 🔴 CI is consistent or not, however shouldn't be related to this change
|
jenkins test this please |
jsvd
added a commit
to jsvd/logstash
that referenced
this pull request
May 25, 2023
This reverts commit 0df07d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.