Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove license header from settings.xml template #15131

Merged
merged 1 commit into from Jun 30, 2023

Conversation

robbavey
Copy link
Member

When using a proxy with the plugin manager, this template is written to ~/.m2/settings.xml. The license header is also copied, which generates invalid XML which maven cannot parse.

Fixes: #15130

When using a proxy with the plugin manager, this template is written to `~/.m2/settings.xml`. The
license header is also copied, which generates invalid XML which maven cannot parse.
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robbavey robbavey merged commit 902b386 into elastic:main Jun 30, 2023
2 of 3 checks passed
@robbavey
Copy link
Member Author

@logstashmachine backport 8.8

@robbavey
Copy link
Member Author

@logstashmachine backport 8.9

github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
When using a proxy with the plugin manager, this template is written to `~/.m2/settings.xml`. The
license header is also copied, which generates invalid XML which maven cannot parse.

(cherry picked from commit 902b386)
github-actions bot pushed a commit that referenced this pull request Jun 30, 2023
When using a proxy with the plugin manager, this template is written to `~/.m2/settings.xml`. The
license header is also copied, which generates invalid XML which maven cannot parse.

(cherry picked from commit 902b386)
jsvd pushed a commit that referenced this pull request Jul 4, 2023
When using a proxy with the plugin manager, this template is written to `~/.m2/settings.xml`. The
license header is also copied, which generates invalid XML which maven cannot parse.

(cherry picked from commit 902b386)

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin updates behind a proxy may fail due to invalid Maven settings.xml
3 participants