Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates i18n.t method calls to avoid deprecated synthax #15500

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Oct 25, 2023

Release notes

Updates callsites synthax for i18n.t method to avoid deprecated and prohibited format

What does this PR do?

Updates invocations of i18n.t method which are leftovers and missed in the original Ruby 3.1 update PR #14861

Why is it important/What is the impact to the user?

Without this, some error reporting logs are hidden by the mismatch of arguments error in translate the error message.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    -~~ [ ] I have added tests that prove my fix is effective or that my feature works~~

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@andsel andsel self-assigned this Oct 25, 2023
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @andsel

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 90964fb into elastic:main Oct 25, 2023
6 checks passed
@andsel
Copy link
Contributor Author

andsel commented Oct 25, 2023

@logstashmachine backport 8.11

github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
…rohibited format (#15500)

Updates invocations of i18n.t method which are leftovers and missed in the original Ruby 3.1 update PR #14861

Without this, some error reporting logs are hidden by the mismatch of arguments error in translate the error message.

(cherry picked from commit 90964fb)
andsel added a commit that referenced this pull request Oct 25, 2023
…rohibited format (#15500) (#15501)

Updates invocations of i18n.t method which are leftovers and missed in the original Ruby 3.1 update PR #14861

Without this, some error reporting logs are hidden by the mismatch of arguments error in translate the error message.

(cherry picked from commit 90964fb)

Co-authored-by: Andrea Selva <selva.andre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong number of arguments for i18n after upgrade to Version 8.10.3
3 participants