Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Logstash to Logstash Native doc to reflect the multiple hosts usage. #15512

Merged
merged 3 commits into from Nov 6, 2023

Conversation

mashhurs
Copy link
Contributor

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@mashhurs mashhurs added the docs label Oct 27, 2023
@mashhurs mashhurs self-assigned this Oct 27, 2023
roaksoax

This comment was marked as outdated.

roaksoax

This comment was marked as outdated.

Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking, we need to talk about what it means to do multiple hosts and how it works, generally speaking.

We also need to update all the section under https://github.com/elastic/logstash/blob/main/docs/static/ls-ls-config.asciidoc?plain=1#L18 to reflect the fact that we will now support loadbalancing.

docs/static/ls-ls-native.asciidoc Show resolved Hide resolved
docs/static/ls-ls-config.asciidoc Outdated Show resolved Hide resolved
docs/static/ls-ls-config.asciidoc Outdated Show resolved Hide resolved
docs/static/ls-ls-native.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm!

docs/static/ls-ls-config.asciidoc Outdated Show resolved Hide resolved
Refining the context.

Co-authored-by: Andres Rodriguez <andreserl@gmail.com>
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mashhurs

@mashhurs mashhurs merged commit fa1382f into elastic:main Nov 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update LS-to-LS native doc after HA support
3 participants