Add support to add and remove multiple keystore keys in a single operation #15612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
force-pushed
the
add-keystore-multi-operation-support
branch
from
9463fee
to
2385532
Compare
Fixed/Added empty and ASCII value validation
edmocosta
force-pushed
the
add-keystore-multi-operation-support
branch
from
2385532
to
f36a46d
Compare
edmocosta
commented
Nov 24, 2023
| final SecretIdentifier id = new SecretIdentifier(argument); | ||
| final byte[] existingValue = secretStore.retrieveSecret(id); | ||
| if (existingValue != null) { | ||
| SecretStoreUtil.clearBytes(existingValue); |
There was a problem hiding this comment.
Wondering if it's really needed?
There was a problem hiding this comment.
I prefer to keep it to avoid jvm dump leak the value
edmocosta
changed the title
kaisecheng
reviewed
Nov 29, 2023
|
|
||
| ["source","sh",subs="attributes"] | ||
| ---------------------------------------------------------------- | ||
| bin/logstash-keystore remove ES_PWD | ||
| bin/logstash-keystore remove ES_USER ES_PWD |
There was a problem hiding this comment.
Let's add a note to remind user that the value should only be ASCII.
| final SecretIdentifier id = new SecretIdentifier(argument); | ||
| final byte[] existingValue = secretStore.retrieveSecret(id); | ||
| if (existingValue != null) { | ||
| SecretStoreUtil.clearBytes(existingValue); |
There was a problem hiding this comment.
I prefer to keep it to avoid jvm dump leak the value
Co-authored-by: kaisecheng <69120390+kaisecheng@users.noreply.github.com>
|
SonarQube Quality Gate
|
💔 Build Failed
Failed CI StepsHistory
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
Why is it important/What is the impact to the user?
Currently, adding keys to the keystore need to call command
logstash-keystore add YOUR_KEYone by one for each key, which is very time-consuming because it starts and stops JVM each time.Checklist
How to test this PR locally
Related issues