Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for 8.13.0 #15978

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Release notes for 8.13.0 #15978

merged 10 commits into from
Mar 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 4, 2024

@kaisecheng kaisecheng marked this pull request as ready for review March 4, 2024 15:23

*Elastic_integration Filter - 0.1.6*

* Using this filter you can process Elastic integrations powered by Elasticsearch Ingest Node in Logstash.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from the plugin description.
"Elastic integrations" is an overloaded term that I am not sure how reader will interpret it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this.

This plugin executes ingest pipeline for each event in Logstash. Once configured to point to an Elasticsearch cluster, this filter will detect which ingest pipeline to execute, using an explicitly-defined pipeline_name or auto-detecting the event’s data-stream and its default pipeline.

Logstash loads ingest pipeline definition from Elasticsearch and runs that pipeline inside Logstash without transmitting the event to Elasticsearch. Any downstream Elasticsearch output in the Logstash pipeline will avoid running the event’s default pipeline again in Elasticsearch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to avoid mentions of "ingest pipeline", please.

Ingest Pipeline is the "how", not the "what" or the "why".


*Elastic_integration Filter - 0.1.6*

* Using this filter you can process Elastic integrations powered by Elasticsearch Ingest Node in Logstash.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to avoid mentions of "ingest pipeline", please.

Ingest Pipeline is the "how", not the "what" or the "why".

docs/static/releasenotes.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
@kaisecheng kaisecheng requested a review from robbavey March 5, 2024 09:03
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


==== Plugins

*Elastic_integration Filter - 0.1.6*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name has to follow the convention with underscore like Elastic_serverless_forwarder


* Package `elastic_integration` plugin. https://github.com/elastic/logstash/pull/15769[#15769]
* Flow metrics added `worker_utilization` to pipeline-level https://github.com/elastic/logstash/pull/15912[#15912]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imap-input plugin is not default now and the change backported to 8.13. Do we need to point it out here?

Comment on lines 75 to 77
* Using this filter you can process Elastic Integrations in Logstash.
** Once configured to point to an Elasticsearch cluster, this filter will detect which Elastic Integration processing (if any) should be executed for each event by auto-detecting the event’s data-stream.
** It will then perform that processing inside Logstash without transmitting the event to Elasticsearch. Events that are successfully handled will be tagged so that any downstream Elasticsearch output in the Logstash pipeline will avoid running the Elastic Integration again in Elasticsearch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin section should reflect the changelog entry for the version bump, not a general description of the plugin.

*Elastic_integration Filter - 0.1.6
https://github.com/elastic/logstash-filter-elastic_integration/pull/127/files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the introduction and add bug fix note of 0.1.6? This is the first time elastic integration filter bundled with Logstash release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the info in release notes, but that's not the right way to handle it.
I'll make some suggestions in the PR .

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
@karenzone karenzone merged commit 270c8ca into 8.13 Mar 26, 2024
4 checks passed
@karenzone karenzone deleted the update_release_notes_1709552189 branch March 26, 2024 00:29
@karenzone
Copy link
Contributor

5847

@karenzone
Copy link
Contributor

@logstashmachine backport main

github-actions bot added a commit that referenced this pull request Mar 26, 2024
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
Co-authored-by: kaisecheng <69120390+kaisecheng@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Mashhur <mashhur.sattorov@elastic.co>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit 270c8ca)
kaisecheng pushed a commit that referenced this pull request Mar 26, 2024
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
Co-authored-by: kaisecheng <69120390+kaisecheng@users.noreply.github.com>
Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
Co-authored-by: Mashhur <mashhur.sattorov@elastic.co>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit 270c8ca)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants