Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added case insensitive option to regex #3636

Closed
wants to merge 1 commit into from

Conversation

nbvehrfr
Copy link

Hi

I added case insensitive option to regex, so you can use it as /MLB/i

Tim

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@jordansissel
Copy link
Contributor

Thanks for helping improve logstash!

Code looks ok.

I'm not sure how this change fits into our plans for a management api, though, and I am hesitant to add further extensions to the config language until we figure out the path from today's config file to the future's management api.

As a workaround until we figure things out, folks can use the (?i) flag within the regexp to have the same effect: /(?i)this Is Case Insensitve/

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

1 similar comment
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@suyograo suyograo closed this May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants