Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Plugin#id that return an ID for a plugin #4525

Closed
wants to merge 2 commits into from

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 19, 2016

This method return an ID for the plugins and be configured by the users
in the configuration like this:

elasticsearch {
  id => "ABC"
  ...
}

This information will be used when collecting metrics for a specific
plugin. Allowing the user to change it allow to stick between restart.

Fixes #3892

@ph
Copy link
Contributor Author

ph commented Jan 19, 2016

@jordansissel So I changed the logic a bit of the #id

By default if the user has not configured anything we will return a UUID.
The user can override this to return something more meaning for them.

@ph ph added the monitoring label Jan 19, 2016
@purbon
Copy link
Contributor

purbon commented Jan 21, 2016

I guess this will need some rebase here.

On the other side, I was not able to see the change for inputs? is there other system for inputs?

for the rest, it LGTM so happy to be merged.

@ph
Copy link
Contributor Author

ph commented Feb 1, 2016

The inputs are covered higher directly in the pipeline.

This method return an ID for the plugins and be configured by the users
in the configuration like this:

```
elasticsearch {
  id => "ABC"
  ...
}
```

This information will be used when collecting metrics for a specific
plugin. Allowing the user to change it allow to stick between restart.

Fixes elastic#3892
@ph ph force-pushed the metrics/fix-plugin-id-logic branch from 212a95c to 4e84836 Compare February 1, 2016 15:01
@elasticsearch-bot
Copy link

Pier-Hugues Pellerin merged this into the following branches!

Branch Commits
feature/metrics 1a780ab, ac2e030

elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
This method return an ID for the plugins and be configured by the users
in the configuration like this:

```
elasticsearch {
  id => "ABC"
  ...
}
```

This information will be used when collecting metrics for a specific
plugin. Allowing the user to change it allow to stick between restart.

Fixes #3892

Fixes #4525
elasticsearch-bot pushed a commit that referenced this pull request Feb 1, 2016
@ph ph closed this Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants