Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default plugins for 5.0 #5254

Closed
wants to merge 2 commits into from
Closed

Conversation

suyograo
Copy link
Contributor

@suyograo suyograo commented May 6, 2016

5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins.

Removed plugins:

logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint
logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker
logstash-codec-netflow: not sure about this.
logstash-filter-multiline: deprecated
logstash-output-hipchat: not maintained. Still at v1 of API.
logstash-output-juggernaut: less usage

Please comment if you'd like to remove more/less

/cc @acchen97 @jordansissel

@ph
Copy link
Contributor

ph commented May 6, 2016

Concerning logstash-codec-netflow, we have a new community maintainer for it, and I can say he is really active.

logstash-output-hipchat Was completely rewritten by me a few month ago and It does support the v2 api and we use the official hipchat gem for it.

logstash-input-zeromq/output and juggernaut I am OK with it.
logstash-filter-multiline, this one is the elephant in the room, but since we are moving away from having a single worker it doesnt make sense to keep it in the core.

@suyograo
Copy link
Contributor Author

suyograo commented May 6, 2016

@ph we also need to measure if folks are actively using it. Remember these plugins can still be installed via bin/logstash-plugin install

@ph
Copy link
Contributor

ph commented May 6, 2016

@suyograo Agree, we need to find a way to make the rubygems stats meaningful, right now theses stats are obfuscated by our build process.

@acchen97
Copy link
Contributor

acchen97 commented May 6, 2016

@suyograo I'm +1 on keeping netflow codec in for now. You've removed most of the ones I had in mind, here's a few others proposals.

Remove:

  • ganglia output
  • gelf output
  • nagios output
  • nagios_nsca output
  • null output

Add:

  • translate filter
  • webhdfs output

@ph
Copy link
Contributor

ph commented May 9, 2016

@acchen97 I am +1 with your proposed changes

@jsvd
Copy link
Member

jsvd commented May 12, 2016

I know this has been discussed already but I'm a bit on the fence with removing the multiline filter, as we don't have an alternative solution to dealing with multiline after codec, even if it means using a single input and -w 1

Do we have any statistics on how much this plugin is still used today?

Also, I suggest removing the checksum filter, should have been gone a long time ago logstash-plugins/logstash-filter-checksum#2

@acchen97
Copy link
Contributor

acchen97 commented May 12, 2016

@jsvd this is just for removing multiline filter from default package.

Also, I suggest removing the checksum filter, should have been gone a long time ago logstash-plugins/logstash-filter-checksum#2

+1 on removing this from logstash-plugins org, removing output-elasticsearch_http makes sense too.

@suyograo
Copy link
Contributor Author

suyograo commented May 12, 2016

@jsvd we are proposing to remove multiline filter from the defaults. Since it is deprecated, if someone has the edge case of using it, then can always install it

Suyog Rao and others added 2 commits May 12, 2016 15:06
5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins. 

Removed plugins:

logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint
logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker

Please comment if you'd like to remove more/less
@suyograo suyograo force-pushed the fix/update-default-plugins branch from 091dee5 to f659ce5 Compare May 12, 2016 22:12
@suyograo
Copy link
Contributor Author

@ph @acchen97 can you guys take another look? Updated

@acchen97
Copy link
Contributor

LGTM

1 similar comment
@ph
Copy link
Contributor

ph commented May 13, 2016

LGTM

@elasticsearch-bot
Copy link

Suyog Rao merged this into the following branches!

Branch Commits
master 96c09ea, 33771c1
5.0 1f775e6, e2e995a

elasticsearch-bot pushed a commit that referenced this pull request May 13, 2016
5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins.

Removed plugins:

logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint
logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker

Please comment if you'd like to remove more/less

Fixes #5254
elasticsearch-bot pushed a commit that referenced this pull request May 13, 2016
elasticsearch-bot pushed a commit that referenced this pull request May 13, 2016
@suyograo suyograo deleted the fix/update-default-plugins branch May 13, 2016 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants