New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default plugins for 5.0 #5254
Conversation
Concerning
logstash-input-zeromq/output and juggernaut I am OK with it. |
@ph we also need to measure if folks are actively using it. Remember these plugins can still be installed via |
@suyograo Agree, we need to find a way to make the rubygems stats meaningful, right now theses stats are obfuscated by our build process. |
@suyograo I'm +1 on keeping netflow codec in for now. You've removed most of the ones I had in mind, here's a few others proposals. Remove:
Add:
|
@acchen97 I am +1 with your proposed changes |
I know this has been discussed already but I'm a bit on the fence with removing the multiline filter, as we don't have an alternative solution to dealing with multiline after codec, even if it means using a single input and -w 1 Do we have any statistics on how much this plugin is still used today? Also, I suggest removing the checksum filter, should have been gone a long time ago logstash-plugins/logstash-filter-checksum#2 |
@jsvd this is just for removing multiline filter from default package.
+1 on removing this from logstash-plugins org, removing output-elasticsearch_http makes sense too. |
@jsvd we are proposing to remove multiline filter from the defaults. Since it is deprecated, if someone has the edge case of using it, then can always install it |
5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins. Removed plugins: logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker Please comment if you'd like to remove more/less
091dee5
to
f659ce5
Compare
LGTM |
1 similar comment
LGTM |
5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins. Removed plugins: logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker Please comment if you'd like to remove more/less Fixes #5254
5.0 is a chance for us to review and remove any plugins that we don't have to bundle by default. These plugins are still supported and maintained, but the default package should only contain most popular, most used plugins.
Removed plugins:
logstash-filter-anonymize: Replaced with newer logstash-filter-fingerprint
logstash-input-zeromq/output: Not a lot of users. Most users seem to prefer rabbitmq, redis, kafka as broker
logstash-codec-netflow: not sure about this.
logstash-filter-multiline: deprecated
logstash-output-hipchat: not maintained. Still at v1 of API.
logstash-output-juggernaut: less usage
Please comment if you'd like to remove more/less
/cc @acchen97 @jordansissel