Deprecate uninstall for Plugin Manager #6042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyograo
commented
Oct 13, 2016
| @@ -25,7 +25,6 @@ gem "docker-api", "1.31.0", :group => :development | |||
| gem "pleaserun" | |||
There was a problem hiding this comment.
ugh, not intentional
pickypg
reviewed
Oct 13, 2016
| context "when the plugin isn't installed" do | ||
| it "fails to remove it" do | ||
| result = logstash.run_command_in_path("bin/logstash-plugin remove logstash-filter-qatest") | ||
| expect(result.stderr).to match(/ERROR: Uninstall Aborted, message: This plugin has not been previously installed, aborting/) |
There was a problem hiding this comment.
Uninstall Aborted -> Remove Aborted
pickypg
reviewed
Oct 13, 2016
| expect(logstash).to have_installed?("logstash-filter-qatest") | ||
|
|
||
| result = logstash.run_command_in_path("bin/logstash-plugin remove logstash-filter-qatest") | ||
| expect(result.stdout).to match(/^Uninstalling logstash-filter-qatest/) |
pickypg
approved these changes
Oct 13, 2016
ph
suggested changes
Oct 13, 2016
| @@ -1,13 +1,16 @@ | |||
| # encoding: utf-8 | |||
There was a problem hiding this comment.
Maybe we could make the uninstall inherits the remove command, override #execute and call super? This would make sure don't have any duplicated code around.
There was a problem hiding this comment.
I just want to have something real quick for 5.0. I understand it is dup code, but I don't want to break stuff
There was a problem hiding this comment.
Good for me, we will remove it in 5.1? correct?
|
LGTM |
Adds remove and deprecates uninstall Fixes elastic#6041
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remove and deprecates uninstall to be consistent with rest of Elastic stack
Fixes #6041