Add IMPORTANT block for path.settings #6068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this breaking change will catch the unsuspecting off guard, make it very visible in the breaking changes documentation
|
LGTM, assuming it builds OK in asciidoc. I've not used that syntax for notes before. |
|
It should. It's one of the 2 acceptable syntaxes for note blocks. |
|
Aaron Mildenstein merged this into the following branches!
|
untergeek
added a commit
that referenced
this pull request
Oct 17, 2016
As this breaking change will catch the unsuspecting off guard, make it very visible in the breaking changes documentation Fixes #6068
jordansissel
pushed a commit
that referenced
this pull request
Oct 28, 2016
As this breaking change will catch the unsuspecting off guard, make it very visible in the breaking changes documentation Fixes #6068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this breaking change will catch the unsuspecting off guard, make it very visible in the breaking changes documentation
Apologies for my editor pruning so many trailing spaces.