Refactor non_reloadable_plugin
#6499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a list of non reloadable plugin we add a new class method on the base plugin class that the plugin will override. By default we assume that all plugins are reloadable, only the stdin shouldn't be reloadable.
|
I will take a look at the failling test, doesn't fail locally, will have to add debug log for travis. |
|
make sure you use logstash-plugins/logstash-input-stdin#14 :) |
|
LGTM |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 25, 2017
Instead of using a list of non reloadable plugin we add a new class method on the base plugin class that the plugin will override. By default we assume that all plugins are reloadable, only the stdin shouldn't be reloadable. Fixes #6499
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 25, 2017
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a list of non reloadable plugin we add a new class
method on the base plugin class that the plugin will override.
By default we assume that all plugins are reloadable, only the stdin
shouldn't be reloadable.