Allow to run the bin/logstash-plugin install <pack> outside of the logstash directory #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logstash directory Fixes: elastic#6599
ph
changed the title
suyograo
reviewed
Jan 31, 2017
|
|
||
| # Some of the internal classes requires to be inside the LOGSTASH_HOME to find the relative | ||
| # path of the core gems. | ||
| Dir.chdir(LogStash::Environment::LOGSTASH_HOME) do |
There was a problem hiding this comment.
Does this undo the chdir after it's done?
There was a problem hiding this comment.
Yes its a block, it will return to the original directory:
puts "current dir: #{Dir.pwd}"
Dir.chdir("/Users/ph") do
puts "current dir: #{Dir.pwd}"
end
puts "current dir: #{Dir.pwd}"⚙ph@sashimi/tmp ruby testing.rb
current dir: /private/tmp
current dir: /Users/ph
current dir: /private/tmp
⚙ph@sashimi/tmp
suyograo
suggested changes
Jan 31, 2017
suyograo
approved these changes
Jan 31, 2017
|
LGTM |
|
@ph this needs to go to 5.2 as well |
|
Pier-Hugues Pellerin merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to run the bin/logstash-plugin install outside of the logstash directory
Fixes: #6599