Update pleaserun and system-install

[untergeek]

This will now put ENV variables from the startup.options file into /etc/default/logstash or /etc/sysconfig/logstash (or whatever service name you chose), and use the updated pleaserun to ensure these are honored at start time for whichever init system you use (systemd, upstart, SysV).

fixes #6482

[jordansissel]

Testing manually, I made this change to the startup.options:

-LS_HOME=/usr/share/logstash
+LS_HOME=/somewhere/over/the/rainbow

Running with this patch:

% sudo bin/system-install config/startup.options upstart
...
% grep LS_HOME /etc/default/logstash
LS_HOME="/somewhere/over/the/rainbow"

Looking good. The rest of the file (/etc/default/logstash) has many variables set -- all of which I expect to have been forwarded from startup.options based on this PR.

Testing master (without this patch):

% sudo bin/system-install config/startup.options upstart
% wc -l /etc/default/logstash
0 /etc/default/logstash

LGTM!

[jordansissel]

Tested manually. LGTM.

[suyograo]

LGTM

[elasticsearch-bot]

Aaron Mildenstein merged this into the following branches!

Branch	Commits
master	0d90e12