Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps and convert to TypeScript #15

Merged
merged 14 commits into from
Feb 15, 2022
Merged

Conversation

pugnascotia
Copy link
Collaborator

Upgrade all dependencies and convert the project to TypeScript. Also switch to peggy instead of PegJS, since apparently the latter is no longer maintained.

GitHub doesn't do a good job with the diff, but you can clone the repo and do the following for a better view:

git diff -M05 main convert-to-typescript

I'm undecided if using JSONValue is a good idea for modelling inputs and outputs, or if I should just use any or unknown. Feedback welcome.

@pugnascotia pugnascotia added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 10, 2022
@pugnascotia
Copy link
Collaborator Author

@chandlerprall would you mind taking a look at this please? 🙏

Copy link

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; didn't test any of the changes, but did compare each. Paid extra attention to the src->dist setup.

@pugnascotia pugnascotia merged commit 4c1973c into main Feb 15, 2022
@pugnascotia pugnascotia deleted the convert-to-typescript branch February 15, 2022 09:37
@pugnascotia
Copy link
Collaborator Author

pugnascotia commented Feb 15, 2022

Released in v1.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants