[ML] Improvements to upfront memory estimation for data frame analyses #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
retest |
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a double counting bug for the memory used by the extra columns for classification and regression model training. It also means they only count towards the data frame memory usage: previously they were wrongly being treated as features for memory estimation purposes.
Incidentally, it also fixes the memory reported by the counter
E_DFOEstimatedPeakMemoryUsage, which was missing the extra columns' memory usage.Finally, it tidies up instrumentation of outlier detection, to more fully use the new instrumentation class, and corrects the memory estimates in
testRunOutlierDetectionPartitioned.