Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix override of maximum permitted trees for classification and regression #1185

Merged
merged 3 commits into from May 4, 2020

Conversation

tveasey
Copy link
Contributor

@tveasey tveasey commented May 4, 2020

This was being reset when searching for the best learn rate. We were also missing a unit test that user overrides for hyperparameters are respected.

@tveasey tveasey changed the title [ML] Fix override maximum permitted trees for classification and regression [ML] Fix override of maximum permitted trees for classification and regression May 4, 2020
@tveasey
Copy link
Contributor Author

tveasey commented May 4, 2020

retest

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tveasey tveasey merged commit 7a506fd into elastic:master May 4, 2020
@tveasey tveasey deleted the override-max-trees branch May 4, 2020 15:12
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request May 4, 2020
tveasey added a commit that referenced this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants