[ML] Don't use higher resolution for cyclic component models than data bucketing supports #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome buckets never being updated
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
Jul 23, 2018
…a bucketing supports (elastic#163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #134, we now have the possibility that we can use more models for cyclic components (seasonal or calendar) than we have measurement buckets in their periods. This means (pigeonhole principle) we'll potentially end up with models which never get updated. To avoid this undesirable situation this change means we refuse to split into more than "measurement buckets per period" models.
This can affect results where the bucket length is long w.r.t. periodicities present in the data. Since this is a correction for unreleased code, it is marked as a non-issue.