Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Upgrade Boost to version 1.77 #2095

Merged
merged 6 commits into from Nov 3, 2021

Conversation

droberts195
Copy link
Contributor

We have been using Boost version 1.71 for a long time
now, and it's good to upgrade occasionally.

Version 1.77 contains support for macOS on ARM, so
upgrading to this version avoids the need to hack the
Boost build files.

We have been using Boost version 1.71 for a long time
now, and it's good to upgrade occasionally.

Version 1.77 contains support for macOS on ARM, so
upgrading to this version avoids the need to hack the
Boost build files.
@droberts195
Copy link
Contributor Author

retest

@droberts195
Copy link
Contributor Author

For Linux we need to allow extra system calls, because since boostorg/filesystem@e2e4b85 boost::filesystem::unique_path uses the getrandom syscall on Linux, and since boostorg/filesystem@3e8c8b1 boost::filesystem::create_directories uses the statx syscall on Linux.

@droberts195 droberts195 marked this pull request as ready for review November 2, 2021 19:36
@droberts195
Copy link
Contributor Author

retest

Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 8925b6e into elastic:main Nov 3, 2021
@droberts195 droberts195 deleted the upgrade-boost branch November 3, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants