[ML] Fix potential use of unintialised value when minimising lowess regression function #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tveasey
added a commit
to tveasey/ml-cpp-1
that referenced
this pull request
May 16, 2022
…egression function (elastic#2268) If for any reason the extrapolation range for lowess regression returns zero then globalMinimize, to find the function minimum, would be supplied an empty collection of points and fail. This would then lead to minimum returning a uninitialised value for the minimum. This shouldn't normally happen in our usage of it, but we have seen the error message associated with supplying an empty collection to globalMinimize in our QA suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for any reason the extrapolation range for lowess regression returns zero then
globalMinimize, to find the function minimum, would be supplied an empty collection of points and fail. This would then lead tominimumreturning a uninitialised value for the minimum. This shouldn't normally happen in our usage of it, but we have seen the error message associated with supplying an empty collection toglobalMinimizein our QA suite.