[ML] Prevent adding new seasonal and calendar components to comply with hard limit #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy42
changed the title
tveasey
reviewed
May 18, 2023
|
@tveasey Thank you for your comments. I addressed all of them. It would be great if you could take another look. |
tveasey
approved these changes
May 25, 2023
lib/model/CEventRateModel.cc
Outdated
| @@ -365,6 +366,8 @@ void CEventRateModel::sample(core_t::TTime startTime, | |||
| annotationCallback(annotation); | |||
| }); | |||
|
|
|||
| params.memoryCircuitBreaker(CMemoryCircuitBreaker(resourceMonitor)); | |||
There was a problem hiding this comment.
nit: couldn't this just be appended to the list above?
| @@ -525,6 +526,7 @@ void CEventRatePopulationModel::sample(core_t::TTime startTime, | |||
| LOG_TRACE(<< "Model unexpectedly null"); | |||
| continue; | |||
| } | |||
| params.memoryCircuitBreaker(CMemoryCircuitBreaker(resourceMonitor)); | |||
|
retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves anomaly detection job compliance with the hard memory limit. It does this by ensuring that the anomaly detection job does not add new seasonal and calendar components to the probability model while it is in the
hard_limitstate.See also #373.