[ML] Improve autodetect logic for persistence #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the logic surrounding persistence of both state and quantiles on graceful shutdown so that persistence only occurs if and only if at least one input record has been processed or time has been advanced. closes elastic#393
droberts195
reviewed
Mar 8, 2019
| if (m_NumRecordsHandled == 0) { | ||
| LOG_DEBUG(<< "Zero records were handled - will not attempt to persist " | ||
| << description << "."); | ||
| return false; |
There was a problem hiding this comment.
In the case of a categorizer chained to an anomaly detector this might not be correct - it's possible that time has been advanced on the anomaly detector.
So this method needs a // Pass on the request in case we're chained step like some of the other methods in this class have. If the chained processor's isPersistenceNeeded() returns true then this method should return true, otherwise it should make its own decision using the code that's there now.
droberts195
approved these changes
Mar 18, 2019
lib/api/CFieldDataTyper.cc
Outdated
| @@ -336,6 +336,11 @@ bool CFieldDataTyper::persistState(core::CDataAdder& persister) { | |||
| } | |||
|
|
|||
| bool CFieldDataTyper::isPersistenceNeeded(const std::string& description) const { | |||
| // Pass on the request in case we're chained | |||
| if (m_OutputHandler.isPersistenceNeeded(description) == true) { | |||
There was a problem hiding this comment.
nit: although we prefer == false to !, I think == true is unnecessary for methods that clearly return a bool
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 18, 2019
Changed the logic surrounding persistence of both state and quantiles on graceful shutdown so that persistence only occurs if and only if at least one input record has been processed or time has been advanced. closes elastic#393
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 18, 2019
Changed the logic surrounding persistence of both state and quantiles on graceful shutdown so that persistence only occurs if and only if at least one input record has been processed or time has been advanced. closes elastic#393
This was referenced Mar 18, 2019
edsavage
added a commit
to edsavage/ml-cpp
that referenced
this pull request
Mar 18, 2019
Changed the logic surrounding persistence of both state and quantiles on graceful shutdown so that persistence only occurs if and only if at least one input record has been processed or time has been advanced. closes elastic#393
edsavage
added a commit
that referenced
this pull request
Mar 18, 2019
edsavage
added a commit
that referenced
this pull request
Mar 18, 2019
edsavage
added a commit
that referenced
this pull request
Mar 18, 2019
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Fixes elastic#394
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Fixes #394
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in elastic#437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of elastic#512
This was referenced Jun 27, 2019
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
droberts195
added a commit
that referenced
this pull request
Jun 27, 2019
Similar to the fix for state and quantiles in #437, if no input is received and time is not advanced then there is no need to write model size stats when the autodetect process exits. Doing this can actually cause a problem for a job that has never ever seen any input, as the unnecessary model size stats were written with a negative timestamp. This change also adds an extra defensive check to prevent that ever happening, although the only situation when it is thought to be possible should be prevented by the first change. Backport of #512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the logic surrounding persistence of both state and quantiles on
graceful shutdown so that persistence only occurs if and only if at
least one input record has been processed or time has been advanced.
closes #393