-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit prediction_probability field alongside prediction field in ml results. #818
Merged
przemekwitek
merged 2 commits into
elastic:master
from
przemekwitek:prediction_probability
Nov 20, 2019
Merged
Emit prediction_probability field alongside prediction field in ml results. #818
przemekwitek
merged 2 commits into
elastic:master
from
przemekwitek:prediction_probability
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
prediction_probability
branch
4 times, most recently
from
November 14, 2019 12:41
224905a
to
03a8851
Compare
dimitris-athanasiou
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You will need to add an entry in the changelog though. |
przemekwitek
force-pushed
the
prediction_probability
branch
from
November 20, 2019 07:56
03a8851
to
c34bde7
Compare
Done. |
run elasticsearch-ci |
przemekwitek
force-pushed
the
prediction_probability
branch
from
November 20, 2019 09:31
1202bc4
to
d77bb6c
Compare
przemekwitek
added a commit
to przemekwitek/ml-cpp
that referenced
this pull request
Nov 20, 2019
przemekwitek
added a commit
that referenced
this pull request
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the user can request
top_classes
(containing class names and probabilities) to be emitted, it seems reasonable to also include the top class' prediction probability as a field alongside the prediction field.