Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit prediction_probability field alongside prediction field in ml results. #818

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Nov 12, 2019

Even though the user can request top_classes (containing class names and probabilities) to be emitted, it seems reasonable to also include the top class' prediction probability as a field alongside the prediction field.

@przemekwitek przemekwitek force-pushed the prediction_probability branch 4 times, most recently from 224905a to 03a8851 Compare November 14, 2019 12:41
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou
Copy link
Contributor

You will need to add an entry in the changelog though.

@przemekwitek
Copy link
Contributor Author

You will need to add an entry in the changelog though.

Done.

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants