[ML] Use empty base optimization with multiple inheritance #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The empty base optimization is not used by default with multiple inheritance on Windows, but can be enabled using __declspec(empty_bases). The investigation in elastic#842 shows which of our classes would benefit, so this PR adds the required option to the 5 affected classes.
droberts195
added a commit
to droberts195/ml-cpp
that referenced
this pull request
Nov 22, 2019
The empty base optimization is not used by default with multiple inheritance on Windows, but can be enabled using __declspec(empty_bases). The investigation in elastic#842 shows which of our classes would benefit, so this PR adds the required option to the 5 affected classes. Backport of elastic#844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The empty base optimization is not used by default with
multiple inheritance on Windows, but can be enabled using
__declspec(empty_bases). The investigation in #842 shows
which of our classes would benefit, so this PR adds the
required option to the 5 affected classes.