Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy setup docs for Elastic Agent and Fleet #1239

Merged
merged 7 commits into from
Dec 7, 2021
Merged

Add proxy setup docs for Elastic Agent and Fleet #1239

merged 7 commits into from
Dec 7, 2021

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Nov 6, 2021 •
edited
Loading

Describes how to set up Elastic Agent and Fleet to communicate through a proxy server.

I have quite a few questions about these steps because I don't have the environment needed to test them. I also need help with examples. But hopefully the basic structure and info is correct.

Preview link: https://observability-docs_1239.docs-preview.app.elstc.co/guide/en/fleet/master/fleet-agent-proxy-support.html

Closes #593

@dedemorton dedemorton self-assigned this Nov 6, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Nov 6, 2021 •
edited
Loading

A documentation preview will be available soon:

@dedemorton dedemorton marked this pull request as ready for review November 9, 2021 03:12
@dedemorton dedemorton requested a review from a team as a code owner November 9, 2021 03:12
@dedemorton dedemorton changed the title [very drafty] Add proxy setup docs for Elastic Agent and Fleet Add proxy setup docs for Elastic Agent and Fleet Nov 9, 2021
@dedemorton dedemorton added v7.16.0 Team:Fleet Label for the Fleet team Team:Elastic-Agent Label for the Agent team labels Nov 9, 2021
@dedemorton dedemorton mentioned this pull request Nov 9, 2021
Closed
@michel-laterman
Copy link
Contributor

@dedemorton, we need to add a section to state that agent.download.proxy_url must be manually set in stand alone mode (in elastic-agent.yml), or injected into fleet.yml as there is no way to set this through the UI

michel-laterman
michel-laterman reviewed Dec 3, 2021
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that it works as I've detailed in 7.15.2

docs/en/ingest-management/fleet-agent-proxy-support.asciidoc Outdated Show resolved Hide resolved
michel-laterman
michel-laterman approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment section looks fine to me. I think we're just missing a section about adding agent.download.proxy_url but we're fine otherwise

docs/en/ingest-management/fleet-agent-proxy-support.asciidoc Show resolved Hide resolved
@mostlyjason
Copy link
Contributor

mostlyjason commented Dec 6, 2021 •
edited
Loading

@dedemorton as a general comment, I feel like we should test the steps in this doc to make sure all the functionality works. I'm concerned that when we initially launched this feature we missed something as important as where to set the environment variables. Are you testing it or should we ask the QA team to try it? One advantage of asking QA to do it, is that we might discover steps that need more clarification.

@mostlyjason
Copy link
Contributor

@EricDavisX Adding you here since it'd be great for the QA to test it once its done. It sounds like Dede didn't have the proper test environment, and the original engineer who worked on it is no longer with the company.

CC @nimarezainia since this is a control plane feature

michel-laterman
michel-laterman approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dedemorton
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs skiplinkcheck

@dedemorton dedemorton merged commit 7e4e5d6 into elastic:main Dec 7, 2021
@dedemorton dedemorton deleted the issue#593 branch December 7, 2021 18:30
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Dec 7, 2021
@dedemorton
Add proxy setup docs for Elastic Agent and Fleet (elastic#1239)
c6d56a7 
* Add proxy setup docs for Elastic Agent and Fleet

* Add changes from review

* More changes from review

* Apply additional chagnes from the review

* Add section about where to set env vars

* Add revisions from review

* Resolve reamining commments from mostlyjason
@dedemorton dedemorton mentioned this pull request Dec 7, 2021
Merged
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Dec 7, 2021
@dedemorton
Add proxy setup docs for Elastic Agent and Fleet (elastic#1239)
01e56b6 
* Add proxy setup docs for Elastic Agent and Fleet

* Add changes from review

* More changes from review

* Apply additional chagnes from the review

* Add section about where to set env vars

* Add revisions from review

* Resolve reamining commments from mostlyjason
@dedemorton dedemorton mentioned this pull request Dec 7, 2021
Merged
dedemorton added a commit that referenced this pull request Dec 7, 2021
@dedemorton
Add proxy setup docs for Elastic Agent and Fleet (#1239) (#1332)
326a839 
* Add proxy setup docs for Elastic Agent and Fleet

* Add changes from review

* More changes from review

* Apply additional chagnes from the review

* Add section about where to set env vars

* Add revisions from review

* Resolve reamining commments from mostlyjason
dedemorton added a commit that referenced this pull request Dec 7, 2021
@dedemorton
Add proxy setup docs for Elastic Agent and Fleet (#1239) (#1331)
d24542d 
* Add proxy setup docs for Elastic Agent and Fleet

* Add changes from review

* More changes from review

* Apply additional chagnes from the review

* Add section about where to set env vars

* Add revisions from review

* Resolve reamining commments from mostlyjason
bmorelli25 pushed a commit to bmorelli25/observability-docs that referenced this pull request Apr 11, 2023
@dedemorton
Add proxy setup docs for Elastic Agent and Fleet (elastic#1239)
b85c49e 
* Add proxy setup docs for Elastic Agent and Fleet

* Add changes from review

* More changes from review

* Apply additional chagnes from the review

* Add section about where to set env vars

* Add revisions from review

* Resolve reamining commments from mostlyjason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin left review comments

@craiglawson craiglawson craiglawson left review comments

@gbanasiak gbanasiak gbanasiak left review comments

@jlind23 jlind23 jlind23 left review comments

@bataya0 bataya0 bataya0 left review comments

@mostlyjason mostlyjason mostlyjason approved these changes

@michel-laterman michel-laterman michel-laterman approved these changes

Assignees

@dedemorton dedemorton

Labels
Team:Elastic-Agent Label for the Agent team Team:Fleet Label for the Fleet team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy setup for agent
9 participants
@dedemorton @apmmachine @michel-laterman @mostlyjason @ruflin @craiglawson @gbanasiak @jlind23 @bataya0