Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump node from 14-alpine to 18-alpine #153

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2022

Bumps node from 14-alpine to 18-alpine.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Apr 25, 2022
@dependabot dependabot bot requested a review from a team April 25, 2022 13:07
@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels Apr 25, 2022
@apmmachine
Copy link
Collaborator

apmmachine commented Apr 25, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-27T21:11:41.605+0000

  • Duration: 8 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is opbeans-node for demo and tests, I'm fine with us tracking the latest node.js major version, if it doesn't cause problems.

Should we be updating other node versions in containers?

.github/workflows/lint.yml
20:        node-version: '14'

docker-compose.yml
160:    image: node:12-bullseye

docker-compose-elastic-cloud.yml
110:    image: node:12-bullseye

.ci/bump-version.sh
13:  node:12-alpine /bin/sh -c "set -x

Makefile
4:LTS_ALPINE ?= 12-alpine

See also #129 which brings up potential dependency issues if the docker-compose files are bumped to node 16. I'll open a separate issue for this: #155

@trentm
Copy link
Member

trentm commented Apr 25, 2022

@astorm Do you have any opinions on this PR or the comments above?

Bumps node from 14-alpine to 18-alpine.

---
updated-dependencies:
- dependency-name: node
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/docker/node-18-alpine branch from f7edaa8 to 2cba8e1 Compare April 27, 2022 21:11
@trentm trentm merged commit 1a1f796 into main Apr 27, 2022
@trentm trentm deleted the dependabot/docker/node-18-alpine branch April 27, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. community dependencies Pull requests that update a dependency file docker Pull requests that update Docker code triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants