feat: make API server to demonstrate distributed tracing #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
commented
Sep 19, 2018
api.js
Outdated
| 'use strict' | ||
|
|
||
| var conf = require('./server/config') | ||
| var apm = require('elastic-apm-node').start(conf.apm) |
There was a problem hiding this comment.
@watson This currently shares the apm configs with the parent app. Should I give it a different serviceName though?
There was a problem hiding this comment.
Yes, we want it to have a different service name to show up separately in the service map UI
|
This will require a corresponding change to either update or move the |
watson
reviewed
Sep 21, 2018
watson
reviewed
Sep 24, 2018
watson
approved these changes
Sep 25, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put the API routes into a separate server and change the
/apimount to use a proxy function withhttp.requestto demonstrate distributed tracing.