Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump standard from 12.0.1 to 16.0.3 #78

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 12, 2021

Bumps standard from 12.0.1 to 16.0.3.

Changelog

Sourced from standard's changelog.

[16.0.3] - 2020-11-17

  • Update eslint from ~7.12.1 to ~7.13.0
  • Relax rule: Enforce default parameters to be last #1414

[16.0.2] - 2020-11-11

  • Allow standard to run on Node 11, even though it's not officially supported #1597

[16.0.1] - 2020-10-30

  • Introduce "warning" system for disruptive rules (read more below)
  • Change rule to a "warning": Require let or const instead of var (no-var) #633

standard treats all rule violations as errors, which means that standard will exit with a non-zero (error) exit code.

However, we may occasionally release a new major version of standard which changes a rule that affects the majority of standard users (for example, transitioning from var to let/const). We do this only when we think the advantage is worth the cost and only when the rule is auto-fixable.

In these situations, we have a "transition period" where the rule change is only a "warning". Warnings don't cause standard to return a non-zero (error) exit code. However, a warning message will still print to the console. During the transition period, using standard --fix will update your code so that it's ready for the next major version.

The slow and careful approach is what we strive for with standard. We're generally extremely conservative in enforcing the usage of new language features. We want using standard to be light and fun and so we're careful about making changes that may get in your way. As always, you can disable a rule at any time, if necessary.

[16.0.0] - 2020-10-28

We're super excited to announce standard 16!

As with every new major release, there are lots of new rules in 16.0.0 designed to help catch bugs and make programmer intent more explicit. This release brings better performance, tons of bug fixes, improved JSX, React ⚛️, and Next.js support!

When you upgrade, consider running standard --fix to automatically format your code to match the newly added rules.

❤️ If you enjoy StandardJS and want to support future releases, please support Feross!

New features

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 12, 2021
@dependabot dependabot bot requested a review from a team April 12, 2021 15:16
@apmmachine
Copy link
Collaborator

apmmachine commented Apr 12, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #78 updated

  • Start Time: 2021-04-12T20:24:39.275+0000

  • Duration: 8 min 52 sec

  • Commit: d9c0761

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

Trends 🧪

Image of Build Times

Image of Tests

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/standard-16.0.3 branch from d759411 to aca6199 Compare April 12, 2021 19:09
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/standard-16.0.3 branch from aca6199 to 91b8c81 Compare April 12, 2021 19:27
@trentm
Copy link
Member

trentm commented Apr 12, 2021

The main affecting major change is this in standard@16.0.0 (https://github.com/standard/standard/blob/master/CHANGELOG.md#1600---2020-10-28):

Require let or const instead of var (no-var) #633 [75%] [automatic fixing reduces to 11%]

After standard --fix we have these remaining:

% npx standard --fix
standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/trentm/el/opbeans-node/server.js:9:18: 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead.
  /Users/trentm/el/opbeans-node/server.js:50:1: Unexpected var, use let or const instead.
  /Users/trentm/el/opbeans-node/server.js:145:1: Unexpected var, use let or const instead.

@trentm trentm self-assigned this Apr 12, 2021
@trentm
Copy link
Member

trentm commented Apr 12, 2021

Tests passing locally with my changes:

% make all
[+] Building 16.1s (13/13) FINISHED
 => [internal] load build definition from Dockerfile                                                                                              0.0s
 => => transferring dockerfile: 37B                                                                                                               0.0s
 => [internal] load .dockerignore                                                                                                                 0.0s
 => => transferring context: 35B                                                                                                                  0.0s
 => [internal] load metadata for docker.io/library/node:12-alpine                                                                                 0.0s
 => [stage-0 1/7] FROM docker.io/library/node:12-alpine                                                                                           0.0s
 => CACHED FROM docker.io/opbeans/opbeans-frontend:latest                                                                                         0.0s
 => => resolve docker.io/opbeans/opbeans-frontend:latest                                                                                          1.2s
 => [internal] load build context                                                                                                                 0.7s
 => => transferring context: 10.85MB                                                                                                              0.7s
 => CACHED [stage-0 2/7] WORKDIR /app                                                                                                             0.0s
 => [stage-0 3/7] ADD . /app                                                                                                                      0.8s
 => [stage-0 4/7] RUN npm install                                                                                                                 2.2s
 => [stage-0 5/7] RUN npm install pm2 -g                                                                                                         11.5s
 => [stage-0 6/7] COPY --from=opbeans/opbeans-frontend:latest /app/build /app/client/build                                                        0.0s
 => [stage-0 7/7] COPY --from=opbeans/opbeans-frontend:latest /app/package.json /app/client/package.json                                          0.0s
 => exporting to image                                                                                                                            0.7s
 => => exporting layers                                                                                                                           0.7s
 => => writing image sha256:13c9c2f4b2ff69dc7e00ca7c53f8ab541d3f09354237312595574deeb72ae730                                                      0.0s
 => => naming to docker.io/opbeans/opbeans-node:latest                                                                                            0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
12-alpine: Pulling from library/node
Digest: sha256:3423a5eea6a1151df079c5e94458dbd946cd53bcb75b47954a16af3137731ec7
Status: Image is up to date for node:12-alpine
docker.io/library/node:12-alpine
Synchronizing submodule url for 'tests/test_helper/bats-assert'
Synchronizing submodule url for 'tests/test_helper/bats-support'
Tests are in progress, please be patient
1..5
ok 1 build image
ok 2 create test container
ok 3 test container is running
ok 4 opbeans is running in port 3000
ok 5 clean test containers
/usr/local/bin/tap-xunit -> /usr/local/lib/node_modules/tap-xunit/bin/tap-xunit
/usr/local/bin/txunit -> /usr/local/lib/node_modules/tap-xunit/bin/tap-xunit
+ tap-xunit@2.4.1
added 21 packages from 21 contributors in 1.726s

@trentm trentm merged commit 669dafb into master Apr 12, 2021
@trentm trentm deleted the dependabot/npm_and_yarn/standard-16.0.3 branch April 12, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants