Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ElasticInfraMetricsProcessor #7

Merged
merged 16 commits into from
Jun 11, 2024

Conversation

ishleenk17
Copy link
Contributor

@ishleenk17 ishleenk17 commented Jun 5, 2024

Description:

Currently, the ElasticInfraMetricsprocessor code is present in this branch (approved and merged).
Move the ElasticInfraMetricsprocessor Code to the Components Repo.
This Processor will be using the elastic/opentelemetry-lib for the translations of metrics from Hostmetrics to System.

The Collector Config will look like below with the processor:

receivers:
  hostmetrics:
    collection_interval: 30s
    scrapers:
      load:
processors:
  resourcedetection/system:
    detectors: ["system", "ec2"]
  elasticinframetrics:
    add_system_metrics: true

exporters:
...............

service:
  pipelines:
    metrics/host:
      receivers: [hostmetrics]
      processors: [resourcedetection/system, elasticinframetrics]

Relates: https://github.com/elastic/opentelemetry-dev/issues/250

Testing:

This processor code has been tested by building a custom collector. The translated metrics are flowing in, confirming that the processor is working correctly.

@ishleenk17 ishleenk17 changed the title Adding the ElasticProcessor Adding the ElasticInfraMetricsProcessor Jun 5, 2024
@ishleenk17 ishleenk17 force-pushed the elasticprocessor_components branch from 8a96084 to 30b6c10 Compare June 5, 2024 19:10
@ishleenk17 ishleenk17 force-pushed the elasticprocessor_components branch from 30b6c10 to be422ae Compare June 5, 2024 19:26
@ishleenk17 ishleenk17 marked this pull request as ready for review June 6, 2024 07:25
@ishleenk17 ishleenk17 requested a review from a team as a code owner June 6, 2024 07:25
@ishleenk17
Copy link
Contributor Author

As discussed with @rogercoll , this PR adds the code for the ElasticInfraMetricsProcesor. The addition of component to the distro will be done as a separate PR.

@ishleenk17 ishleenk17 requested a review from ChrsMark June 10, 2024 06:29
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of follow up comments that can be addressed in a future PR

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for adding the tests!

@ishleenk17 ishleenk17 merged commit ac542d3 into elastic:main Jun 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants