-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the ElasticInfraMetricsProcessor #7
Adding the ElasticInfraMetricsProcessor #7
Conversation
8a96084
to
30b6c10
Compare
30b6c10
to
be422ae
Compare
As discussed with @rogercoll , this PR adds the code for the ElasticInfraMetricsProcesor. The addition of component to the distro will be done as a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of follow up comments that can be addressed in a future PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank's for adding the tests!
Description:
Currently, the ElasticInfraMetricsprocessor code is present in this branch (approved and merged).
Move the ElasticInfraMetricsprocessor Code to the Components Repo.
This Processor will be using the elastic/opentelemetry-lib for the translations of metrics from Hostmetrics to System.
The Collector Config will look like below with the processor:
Relates: https://github.com/elastic/opentelemetry-dev/issues/250
Testing:
This processor code has been tested by building a custom collector. The translated metrics are flowing in, confirming that the processor is working correctly.