Migrate the Hostmetrics<>System mapping code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyers-elastic
approved these changes
May 14, 2024
lahsivjar
reviewed
May 14, 2024
| } | ||
| } | ||
|
|
||
| memUtilPct = memUtil / 100 |
There was a problem hiding this comment.
Is process.memory.utilization not a fraction based %? I see that in CPU utilization we are assuming fraction based number but here we are not.
| startTime = dp.StartTimestamp().AsTime().UnixMilli() | ||
| } | ||
| fdOpen = dp.IntValue() | ||
| } else if metric.Name() == "process.cpu.time" { |
There was a problem hiding this comment.
process.cpu.time is a monotonic true metric - this doesn't look correct.
| } | ||
| } | ||
| } | ||
| } else if metric.Name() == "process.disk.io" { |
There was a problem hiding this comment.
process.disk.io is also a cumulative metric with monotonic true.
lahsivjar
reviewed
May 14, 2024
| } | ||
| } | ||
| } | ||
| } else if metric.Name() == "process.disk.operations" { |
There was a problem hiding this comment.
process.disk.operations is also a cumulative metric with monotonic true.
|
@lahsivjar: As discussed, I will be opening up a separate issue to address the questions about process fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the mapping code of Hostmetrics<>System Integration from the POC branch to this repo.
There would be different users of this library like APM-Server, Elastic Infra Processor etc.
Relates: #3