Add System Package #390
Add System Package #390
Conversation
There was a problem hiding this comment.
I suggest you best add 0.0.2 of the package. And lets get your FB issues fixed @michalpristas
|
I apologize if it's not clear in the instruction (let me know if it is), but in general package data in |
|
Here's the errors I'm seeing in the agent: |
|
This is the suggestion I received from @michalpristas and it worked:
|
|
what marcin said. if this does not help check logs. as PR which makes it easier to find process logs is not in yet my advice would be to allow monitoring if monitoring is not enabled they are usually at the install location of a beat under logs subdir if you stick with default package then it is where the agent is located + we might learn more about what's happening there |
|
Okay, now I'm running into different issues. I can enroll the agent, same as normal, but when I try and view the agent, I get a JS error: No backend errors on the developer console. The agent just reports this: |
|
Also, trying to SIGIT produces a panic: |
|
Okay. Finally got this working. |
fearful-symmetry
force-pushed
the
system-support
branch
from
1f8462e
to
be0504f
Compare
|
Checking over everything now, but I hope this is good. |
| - add_locale: ~ | ||
| - add_fields: | ||
| target: '' | ||
| fields: |
There was a problem hiding this comment.
This is interesting. I wonder if we should add this still on the Beats side in the future. @ph
| @@ -0,0 +1 @@ | |||
| metricsets: ["diskio"] | |||
There was a problem hiding this comment.
Do we miss period here as a config option? And also some other datasets?
There was a problem hiding this comment.
period is at the module level, if that's what you mean?
There was a problem hiding this comment.
No, there are two things here. First I assume this stream template should also contain an entry for the period like few other datasets? The second part is if it is a global option on the package level or per dataset. I think it should be per dataset and you have it specified in some of the datasets already. Important is that it can only be either on the package or the dataset level, not both.
| The available bits of entropy | ||
| - name: pct | ||
| type: scaled_float | ||
| format: percent |
There was a problem hiding this comment.
@skh @neptunian Do we already support formatters in our kibana index patterns?
@fearful-symmetry Nothing to change here.
| "filter": [], | ||
| "query": { | ||
| "language": "kuery", | ||
| "query": "" |
There was a problem hiding this comment.
Not for this PR, but I'm wondering if we could query here for the stream.type and stream.dataset and then this would query much less data.
|
@fearful-symmetry If you would call this 0.0.3 it would be much easier to test as it would be newer then https://github.com/elastic/package-registry/tree/master/dev/packages/example/system/0.0.2 As soon as this PR is merged, I plan to remove my 0.0.2 |
|
@ruflin Sure. Still trying to figure out the readme. |
README files (template and the rendered one) look good. Comparing to other packages I'm missing sample events, but I assume you gonna add real ones later once tested. |
I'm going over the guide here: https://github.com/elastic/package-registry/blob/master/CONTRIBUTING.md#run-the-whole-setup
This is just the result of
env PACKAGES=system mage ImportBeats. I can't really get any farther, as when I try to register and start the agent, filebeat crashes and I can't get any farther.