Add support for owner filed in package manifest #536
Conversation
ruflin
added
the
Ingest Management:beta1
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
To be honest, I'm against this change to prevent community people from pinging single developers instead of using team aliases. There is no plan for fixing this field if the person leaves the company and we won't fix already released packages. I suggest to base on the repository owners here. |
|
I used |
| @@ -28,6 +28,10 @@ license: basic | |||
| # The default type is integration and will be set if empty. | |||
| type: integration | |||
|
|
|||
| # Details about the owner of the package. Current only github link is supported. | |||
| # A package can only have a single owner, the owner can be a user or a team. | |||
There was a problem hiding this comment.
@mtojek I added a comment here to make it more obvious it can be a user or a team.
There was a problem hiding this comment.
Thanks for the explanation. I assume that team aliases will be set for all Elastic packages?
There was a problem hiding this comment.
Yes, I hope so. This was the initial driver for this in #451 Not sure if there is a good way to add this to the generator as in Filebeat for example, some belong to SIEM, some to Platforms team.
In some cases it is important to know who the owner of a package is so this owner can be pinged for questions. In elastic#451 the different options around owner, authors, contributors were discussed. My take away from this discussions which lead to this PR: * There are multiple authors over time * Authors and contributors are mostly exchangeable terms * There can only be 1 owner, even if it is a team. This PR currently only implements `owner.github` because it is all we need. Later on we can add an array of `contributors` and addition owner fields if needed. Closing elastic#451
|
After going through a few merge conflicts and rebases, this should now be ready again @mtojek |
CHANGELOG.md
Outdated
| @@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Support multiple packages paths. [#525](https://github.com/elastic/package-registry/pull/525) | |||
| * Added support for ecs style validation for dataset fields. [#520](https://github.com/elastic/package-registry/pull/520) | |||
| * Use BasePackage for search output data. [#529](https://github.com/elastic/package-registry/pull/529) | |||
| * Add support for owner filed in package manifest. [#535](https://github.com/elastic/package-registry/pull/535) | |||
There was a problem hiding this comment.
fixed. that is what happens if you try to predict the PR number ...
In some cases it is important to know who the owner of a package is so this owner can be pinged for questions. In #451 the different options around owner, authors, contributors were discussed. My take away from this discussions which lead to this PR:
This PR currently only implements
owner.githubbecause it is all we need. Later on we can add an array ofcontributorsand addition owner fields if needed.Closing #451