Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template_path field on inputs #655

Merged
merged 5 commits into from
Nov 20, 2020
Merged

Allow template_path field on inputs #655

merged 5 commits into from
Nov 20, 2020

Conversation

jen-huang
Copy link
Contributor

Follow up to elastic/package-spec#79. Kibana needs template_path to ascertain which input template file to read from to build the agent YAML. This PR lets the registry serve that field at the input level, if defined.

Follow up to elastic/package-spec#79. Kibana needs `template_path` to ascertain which input template file to read from to build the agent YAML. This PR lets the registry serve that field at the input level, if defined.
@elasticmachine
Copy link

elasticmachine commented Nov 19, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #655 updated]

  • Start Time: 2020-11-20T19:40:14.858+0000

  • Duration: 7 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 165
Skipped 0
Total 165

Copy link
Contributor

@jalvz jalvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a new test package with relevant data stream to the testdata/package directory? You can test it with go test .. You will also need to regenerate expected data with go test . -generate.

Please also add a CHANGELOG entry.

@jen-huang
Copy link
Contributor Author

@mtojek Thanks, I added input_level_templates test package and updated changelog.

@jen-huang jen-huang merged commit 6f08e8c into master Nov 20, 2020
@jen-huang jen-huang deleted the jh/input-template branch November 20, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants