Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation that owner is set #20

Closed
ruflin opened this issue Aug 12, 2020 · 3 comments
Closed

Add validation that owner is set #20

ruflin opened this issue Aug 12, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@ruflin
Copy link
Member

ruflin commented Aug 12, 2020

The owner of a package is becoming more important. I think every package "must" specify an owner. The owner can be a group or a single person. The validation script should be able to validate that an owner exists.

An addition to that would be that it even validates if the group / users exists on Github but that might become excessive and cause permissions problems.

@ycombinator
Copy link
Contributor

The validation script should be able to validate that an owner exists.

Concretely what does it mean for an owner to exist? Are owners the same as a user or repo on GitHub? Or is it a team on GitHub? Based on what you said about permissions I think an owner is either a user or team on GitHub — if so, then yes, we could probably validate the existence of a user but not that of a team.

@ruflin
Copy link
Member Author

ruflin commented Aug 14, 2020

Yes, owner should be user or team.

rw-access pushed a commit to rw-access/package-spec that referenced this issue Mar 23, 2021
@mtojek mtojek added the good first issue Good for newcomers label Nov 19, 2021
@jsoriano
Copy link
Member

Owner is already required, and we also enforce the presence of the owners in the GITOWNERS file in the integrations repository. Closing this. Please reopen if something is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants