Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create traces data type #68

Closed
jalvz opened this issue Oct 22, 2020 · 3 comments · Fixed by #78
Closed

Create traces data type #68

jalvz opened this issue Oct 22, 2020 · 3 comments · Fixed by #78

Comments

@jalvz
Copy link
Contributor

jalvz commented Oct 22, 2020

The spec defines 2 data types: metrics and logs (

enum:
- metrics
- logs
).

For the upcoming APM integration we need a new traces data type.

@ruflin
Copy link
Member

ruflin commented Oct 22, 2020

If we add a new data type, this should also be added to Elasticsearch @dakrone

@jalvz
Copy link
Contributor Author

jalvz commented Oct 22, 2020

Thanks @ruflin, anything else I should be aware of?
Regarding EPR is just enough to add the new type to the enum above?

@ruflin
Copy link
Member

ruflin commented Oct 22, 2020

For EPR, yes. It will also need to be added to Kibana to make sure the Kibana index pattern gets generated. @neptunian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants