Add new code to be able to filter legacy visualizations validation rule #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Sep 28, 2023
| @@ -10,4 +10,5 @@ const ( | |||
| CodeKibanaDashboardWithQueryButNoFilter = "SVR00001" | |||
| CodeKibanaDashboardWithoutFilter = "SVR00002" | |||
| CodeKibanaDanglingObjectsIDs = "SVR00003" | |||
| CodeKibanaLegacyVisualizations = "SVR00004" | |||
There was a problem hiding this comment.
New code for legacy visualizations validation rule.
mrodm
commented
Sep 28, 2023
Comment on lines
+28
to
+30
| - description: Add code to filter legacy visualizations validation rule | ||
| type: enhancement | ||
| link: https://github.com/elastic/package-spec/pull/618 |
There was a problem hiding this comment.
Should it be added this changelog entry for this case ?
💚 Build Succeeded
cc @mrodm |
jlind23
approved these changes
Sep 28, 2023
|
I'll set this PR on hold in favor of #619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new code error for those structured errors related to legacy visualizations introduced in #610
Why is it important?
It adds a mechanism to filter these errors (legacy visualizations) in the packages.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues