Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the timestamp field to @timestamp #343

Merged
merged 2 commits into from Nov 2, 2015
Merged

Rename the timestamp field to @timestamp #343

merged 2 commits into from Nov 2, 2015

Conversation

monicasarbu
Copy link
Contributor

  • change timestamp with @timestamp in the code and tests
  • update godeps
  • update docs
  • update changelog

@urso
Copy link

urso commented Nov 2, 2015

Missing:

  • doc/new_protocol.asciidoc
  • etc/sample_outputs/*.json ?

@monicasarbu
Copy link
Contributor Author

Now, timestamp should be renamed everywhere. I am using the following command to check if there are files where timestamp still appears.

 $$ ack --ignore-dir Godeps 'timestamp'  | grep -v "@timestamp"

urso pushed a commit that referenced this pull request Nov 2, 2015
Merge pull request #343 from monicasarbu/packetbeat_rename_timestamp
96ab297 
Rename the timestamp field to @timestamp
@urso urso merged commit 96ab297 into elastic:master Nov 2, 2015
tsg pushed a commit to tsg/beats that referenced this pull request Jan 20, 2016
Merge pull request elastic#343 from monicasarbu/packetbeat_rename_tim…
a96eb2d 
…estamp

Rename the timestamp field to @timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monicasarbu @urso