Exchange all occurences of group => 'root' with group => '0', #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make it more *BSD compatible. There the root group might have different names than 'root'.
|
Thanks for the contribution @buzzdeee, I wasn't aware this was an issue for the *BSDs, so this is useful to know 👍 . The tests seem perfectly happy with it, so it looks safe as well. You're already in |
tylerjl
approved these changes
Sep 21, 2016
cegeka-jenkins
pushed a commit
to cegeka/puppet-elasticsearch
that referenced
this pull request
Oct 23, 2017
Exchange all occurences of group => 'root' with group => '0',
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request acceptance prerequisites:
to make it more *BSD compatible. There the root group might have
different names than 'root'.