Require pyyaml for elastic/security #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes `rally-tracks-compat` in CI tests. Background: The elastic/security track (in `events_emitter.py`) imports `yaml`, but it doesn't explicitly depend on it in `track.json` (and neither does Rally require it). So far things worked because `pyyaml` was required in the older version (`0.0.3`) of Geneve but recently[^1] a new version (`0.1.1`) got released that removed the `pyyaml` dependency[^2] (under the good `geneve` uses `ruamel.yaml`). Since then, we have `rally-tracks-compat` failures[^3]: ``` Running command: [esrally race --track="elastic/security" --challenge="index-alert-source-events" --track-repository="/var/lib/jenkins/workspace/elastic+rally+pull-request+rally-tracks-compat/.rally/benchmarks/tracks/rally-tracks-compat" --track-revision="master" --configuration-name="pytest" --enable-assertions --kill-running-processes --on-error="abort" --pipeline="benchmark-only" --target-hosts="127.0.0.1:19200" --test-mode --track-params="number_of_replicas:0"] 12:14:02 FAILED [ 97%] 12:15:01 [ERROR] Cannot race. Error in load generator [0] 12:15:01 No module named 'yaml' ``` [^1]: https://github.com/elastic/geneve/tags [^2]: elastic/geneve@1f8304f [^3]: https://elasticsearch-ci.elastic.co/job/elastic+rally+pull-request+rally-tracks-compat/160/console
pquentin
approved these changes
Nov 17, 2022
This was referenced Nov 17, 2022
cavokz
approved these changes
Nov 17, 2022
dliappis
added a commit
that referenced
this pull request
Nov 17, 2022
This commit fixes `rally-tracks-compat` in CI tests. Background: The elastic/security track (in `events_emitter.py`) imports `yaml`, but it doesn't explicitly depend on it in `track.json` (and neither does Rally require it). So far things worked because `pyyaml` was required in the older version (`0.0.3`) of Geneve but recently[^1] a new version (`0.1.1`) got released that removed the `pyyaml` dependency[^2] (under the hood `geneve` uses `ruamel.yaml`). Since then, we have `rally-tracks-compat` failures[^3]: ``` Running command: [esrally race --track="elastic/security" --challenge="index-alert-source-events" --track-repository="/var/lib/jenkins/workspace/elastic+rally+pull-request+rally-tracks-compat/.rally/benchmarks/tracks/rally-tracks-compat" --track-revision="master" --configuration-name="pytest" --enable-assertions --kill-running-processes --on-error="abort" --pipeline="benchmark-only" --target-hosts="127.0.0.1:19200" --test-mode --track-params="number_of_replicas:0"] 12:14:02 FAILED [ 97%] 12:15:01 [ERROR] Cannot race. Error in load generator [0] 12:15:01 No module named 'yaml' ``` [^1]: https://github.com/elastic/geneve/tags [^2]: elastic/geneve@1f8304f [^3]: https://elasticsearch-ci.elastic.co/job/elastic+rally+pull-request+rally-tracks-compat/160/console
dliappis
added a commit
that referenced
this pull request
Nov 17, 2022
This commit fixes `rally-tracks-compat` in CI tests. Background: The elastic/security track (in `events_emitter.py`) imports `yaml`, but it doesn't explicitly depend on it in `track.json` (and neither does Rally require it). So far things worked because `pyyaml` was required in the older version (`0.0.3`) of Geneve but recently[^1] a new version (`0.1.1`) got released that removed the `pyyaml` dependency[^2] (under the hood `geneve` uses `ruamel.yaml`). Since then, we have `rally-tracks-compat` failures[^3]: ``` Running command: [esrally race --track="elastic/security" --challenge="index-alert-source-events" --track-repository="/var/lib/jenkins/workspace/elastic+rally+pull-request+rally-tracks-compat/.rally/benchmarks/tracks/rally-tracks-compat" --track-revision="master" --configuration-name="pytest" --enable-assertions --kill-running-processes --on-error="abort" --pipeline="benchmark-only" --target-hosts="127.0.0.1:19200" --test-mode --track-params="number_of_replicas:0"] 12:14:02 FAILED [ 97%] 12:15:01 [ERROR] Cannot race. Error in load generator [0] 12:15:01 No module named 'yaml' ``` [^1]: https://github.com/elastic/geneve/tags [^2]: elastic/geneve@1f8304f [^3]: https://elasticsearch-ci.elastic.co/job/elastic+rally+pull-request+rally-tracks-compat/160/console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes
rally-tracks-compatin CI tests.Background:
The elastic/security track (in
events_emitter.py) importsyaml, but it doesn't explicitly depend on it intrack.json(and neither does Rally require it).So far things worked because
pyyamlwas required in the older version(
0.0.3) of Geneve but recently1 a new version (0.1.1) gotreleased that removed the
pyyamldependency2 (under the goodgeneveusesruamel.yaml).Since then, we have
rally-tracks-compatfailures3:Footnotes
https://github.com/elastic/geneve/tags ↩
https://github.com/elastic/geneve/commit/1f8304ff44b9707c315def34c2ca4b72f00ba9fe ↩
https://elasticsearch-ci.elastic.co/job/elastic+rally+pull-request+rally-tracks-compat/160/console ↩