Use async runners if needed #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852 Relates elastic/rally#916
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852 Relates elastic/rally#916
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852 Relates elastic/rally#916
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852 Relates elastic/rally#916
danielmitterdorfer
added a commit
that referenced
this pull request
Feb 21, 2020
Due to elastic/rally#852 we will implement a compatibility layer in the current load generator that will also use the asyncio API and thus requires custom runners to be registered differently (by specifying `async_runner=True`). Rally's runner registry will also expose a new attribute `async_runner` that is set to `True` if Rally requires runners to be registered as described above. With this commit we introduce a (temporary) compatibility layer for all custom runners that allows older Rally versions to work with the classic runners and newer Rally versions with the async runners. Relates elastic/rally#852 Relates elastic/rally#916
This was referenced Feb 21, 2020
danielmitterdorfer
added a commit
to elastic/rally
that referenced
this pull request
Mar 8, 2020
With this commit we add a new experimental subcommand `race-aync` to Rally. It allows to specify significantly more clients than the current `race` subcommand. The reason for this is that under the hood, `race-async` uses `asyncio` and runs all clients in a single event loop. Contrary to that, `race` uses an actor system under the hood and maps each client to one process. As the new subcommand is very experimental and not yet meant to be used broadly, there is no accompanying user documentation in this PR. Instead, we plan to build on top of this PR and expand the load generator to take advantage of multiple cores before we consider this usable in production (it will likely keep its experimental status though). In this PR we also implement a compatibility layer into the current load generator so both work internally now with `asyncio`. Consequently, we have already adapted all Rally tracks with a backwards-compatibility layer (see elastic/rally-tracks#97 and rally-eventdata-track#80). Closes #852
danielmitterdorfer
added a commit
to elastic/rally
that referenced
this pull request
Mar 29, 2020
With this commit we add a new experimental subcommand `race-aync` to Rally. It allows to specify significantly more clients than the current `race` subcommand. The reason for this is that under the hood, `race-async` uses `asyncio` and runs all clients in a single event loop. Contrary to that, `race` uses an actor system under the hood and maps each client to one process. As the new subcommand is very experimental and not yet meant to be used broadly, there is no accompanying user documentation in this PR. Instead, we plan to build on top of this PR and expand the load generator to take advantage of multiple cores before we consider this usable in production (it will likely keep its experimental status though). In this PR we also implement a compatibility layer into the current load generator so both work internally now with `asyncio`. Consequently, we have already adapted all Rally tracks with a backwards-compatibility layer (see elastic/rally-tracks#97 and elastic/rally-eventdata-track#80). Closes #852 Relates #916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to elastic/rally#852 we will implement a compatibility layer in the
current load generator that will also use the asyncio API and thus
requires custom runners to be registered differently (by specifying
async_runner=True). Rally's runner registry will also expose a newattribute
async_runnerthat is set toTrueif Rally requires runnersto be registered as described above.
With this commit we introduce a (temporary) compatibility layer for all
custom runners that allows older Rally versions to work with the classic
runners and newer Rally versions with the async runners.
Relates elastic/rally#852